Remove TestLowSequenceHandlingNoDuplicates #7318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtion failure for flake caused by issue #3506
torcolvin
previously approved these changes
Jan 24, 2025
… behaviour that doesn't cause functional issues, and there's no easy performant way to prevent this case, in the event that late sequences share common channels.
bbrks
changed the title
torcolvin
approved these changes
Jan 24, 2025
adamcfraser
approved these changes
Jan 24, 2025
torcolvin
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an underlying issue #3056 which describes this behaviour, but late sequences arriving that share channels are not syncronised, which results in changes feeds sometimes emitting sequences without advancing low seq, and causes duplicate sequence entries in the feeds.
This does not cause a functional issue with CBL, and we expect consumers of changes feeds to be able to deduplicate sequences from their feeds.
Test was mistakenly reenabled here since it was passing most of the time by change feed timing coincidence: #7031
Integration Tests